Skip to content

fix(shell): add aria-label to theme toggle button #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lourincedaging0-commits wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −0
Open

fix(shell): add aria-label to theme toggle button #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/Shell.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,5 @@ test('shows nav, endpoint pill, and outlet content when connected', async () =>
expect(screen.getByText('home content')).toBeInTheDocument()
await waitFor(() => expect(screen.getByText('127.0.0.1:8731')).toBeInTheDocument())
expect(screen.queryByText(/connect to your knowledge base/i)).not.toBeInTheDocument()
expect(screen.getByRole('button', { name: /toggle theme/i })).toBeInTheDocument()
})
1 change: 1 addition & 0 deletions src/components/Shell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ export function Shell() {
<button
onClick={() => setTheme(theme === 'dark' ? 'light' : 'dark')}
title="Toggle theme"
aria-label="Toggle theme"
className="rounded-lg p-2 text-sepia transition hover:bg-paper-3 hover:text-ink"
>
<SunMoon size={16} />
Expand Down