fix(export): auto-union multi-part Scenes for STL - #681
Merged
Conversation
Studio header STL on assemblies (e.g. keycap body + inlays) failed with export.no-shape asking for Scene.toUnion(). STL is a single mesh, so fuse world-frame parts automatically — same geometry as an explicit toUnion — while STEP/3MF/GLB keep per-part identity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
STL export of a multi-part assembly Scene (MAKE NO MISTAKES keycap, etc.) failed with
export.no-shape/ use Scene.toUnion(). Studio header STL should just download a mesh.Changes
runAndExport(format: 'stl')on a SceneBackend fuses world-frame parts (boolean union), matchingScene.toUnion()Test plan
vitest run tests/integration/lowering/sceneStepExport.test.ts