fix(admin): ack-emoji picker — proxy fix, auto-save, Slack-style picker - #590
Merged
Conversation
16francej
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #571 — three ack-emoji picker improvements, found/requested while testing live on a Fly deployment.
1. Catalog fetch bypassed the admin proxy. The UI fetched
/v1/admin/slack-emoji, but the admin plugin only forwardsGET /api/<resource>paths — the fetch returned the dashboard shell and the picker's catalog silently never loaded. UI now callsGET /api/slack-emojiandslack-emojiis in the proxied READS.2. Removing a chip didn't persist. Chip add/remove only mutated local state; without pressing Save the change was silently lost. Chip changes now auto-save through the existing save machinery (dirty-mark, then trigger the section save — status text and error handling unchanged).
3. Slack-style emoji picker. The datalist type-ahead is replaced with a proper picker popover: search box, scrollable grid, the org's custom emoji first (with image previews), then the full standard set grouped by Slack's categories. Click to add; Escape closes; Enter picks the first match. The core endpoint now also returns the ordered standard emoji (name, char, category) from emoji-datasource so the picker isn't custom-only.