fix: wire DB_HOST/DB_PORT/DB_NAME/DB_USER/DB_PASSWORD into tes service - #41
Merged
Conversation
TES's run_store.py (Mode B Phase 1A/1B) has its own DB_* defaults
(DB_USER=DB_PASSWORD="omnibioai") that never matched any real MySQL
grant -- that PR's own code comment flagged this exact gap as a known
TODO ("this repo's own docker-compose environment block still needs
that same DB_* set added... omnibioai-studio is a different repo, out
of scope for this change") and it was never followed up on. Confirmed
live: every real /api/runs/submit has been crashing on
RunStore.create()'s MySQL connect this whole time --
"Access denied for user 'omnibioai'@... (using password: YES)".
Wires the same shared DB (mysql/omnibioai) and the same DB_USER=root /
MYSQL_ROOT_PASSWORD credential every other service in this file already
uses -- not a new database, not guessed credentials. Mirrors
workflow-bundles' own existing entry in this same file exactly.
Found and fixed while verifying omnibioai-workbench#196 end-to-end
(TES call sites routed through api-gateway) -- unrelated concern
(gateway routing vs. TES's own persistence layer), kept as its own
commit/branch rather than bundled into #196's GATEWAY_URL change.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TES's
run_store.py(Mode B Phase 1A/1B) has its ownDB_*defaults (DB_USER/DB_PASSWORD="omnibioai") that never matched any real MySQL grant in this deployment. That PR's own code comment flagged this exact gap as a known TODO:It was never followed up on. Confirmed live (found while verifying omnibioai-workbench#196 end-to-end): every real
/api/runs/submithas been crashing onRunStore.create()'s MySQL connect this whole time:Fix
Wires the same shared DB (
mysql/omnibioai) and the sameDB_USER=root/MYSQL_ROOT_PASSWORDcredential every other service indocker-compose.ymlalready uses -- not a new database, not guessed credentials. Mirrorsworkflow-bundles' own existing entry in this same file exactly (DB_HOST: mysql,DB_PORT: "3306",DB_NAME: omnibioai,DB_USER: root,DB_PASSWORD: ${MYSQL_ROOT_PASSWORD:-omnibioai}).Scope note
Found and fixed while doing #196's end-to-end verification (TES call sites routed through api-gateway) -- this is an unrelated concern (TES's own persistence layer vs. gateway routing), kept as its own commit/branch/PR rather than bundled into #196's
GATEWAY_URLchange.Not merging -- flagging for review, same as usual.
🤖 Generated with Claude Code