Fix build reliability and improve subtitle playback performance#88
Merged
dfederm merged 1 commit intoJun 23, 2026
Merged
Conversation
7 tasks
dfederm
requested changes
Jun 19, 2026
dfederm
left a comment
dfederm
left a comment
Owner
There was a problem hiding this comment.
Thanks for contributing! I have a few comments, some of which are blocking.
Going fwd can you try to split logically different changes into separate PRs? It's easier to review and also permits merging some while others are still being reviewed or while comments are being addressed.
This was referenced Jun 20, 2026
Closed
Contributor
Author
|
My bad, I pushed too many changes as one PR before I realized what have I done :) |
dfederm
requested changes
Jun 21, 2026
dfederm
left a comment
dfederm
left a comment
Owner
There was a problem hiding this comment.
looks mostly good. Just rebase onto main and drop the build changes since they're all now moot, leaving this PR purely about subtitle fixes.
Load only the selected external subtitle via IRequestAdapter for Jellyfin-hosted tracks and CreateFromUri for third-party URLs. Route subtitle presentation by DeliveryMethod, cache bitrate per session, and ensure the device profile is initialized before playback info requests.
CyberoniOntoni
force-pushed
the
fix/build-and-subtitle-playback
branch
from
a7dfdc0 to
77bb4a1
Compare
dfederm
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves subtitle playback performance during direct play.
Rebased onto
main; build/restore changes were dropped (addressed upstream in #90 and #92).Subtitle playback
Fixes noticeable lag/stutter when subtitles are enabled during otherwise smooth direct play.
IRequestAdapter.SendPrimitiveAsyncandTimedTextSource.CreateFromStream; third-party URLs useCreateFromUriwithout appending an API key.DeliveryMethod: Embedded and the selected external track are presented client-side; switching to another unloaded external track restarts playback to load it.TimedMetadataTracksChangeddispatcher churn.Test plan
Release | x64)Notes
Tested on Windows (desktop deployment). Intended to benefit Xbox Series X/S as well.