Hide unreleased network-volume commands from --help - #466
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a general-purpose “hidden command” mechanism in the CLI parser to remove unreleased commands from vastai --help output and tab completion, while keeping those commands executable when invoked directly (discoverability gate only).
Changes:
- Adds
HIDDEN_COMMANDS+is_hidden_command()and ahidden=kwarg on@parser.commandto mark commands as hidden. - Filters hidden subparsers out of both grouped
--helprendering and completion map generation. - Adds tests covering the hidden-command registry behavior, decorator propagation, help suppression, and direct parsing of a hidden command.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
vastai/cli/parser.py |
Implements hidden-command metadata and filters hidden commands out of help/completion paths. |
tests/cli/test_parser.py |
Adds unit/sanity tests to ensure hidden commands are not discoverable but remain runnable. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sammy-vastai
marked this pull request as ready for review
July 21, 2026 21:43
vastzuby
approved these changes
Jul 24, 2026
Contributor
|
yeah anything network volume or cluster related should be hidden |
This was referenced Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Network volumes aren't released yet, but their CLI commands were fully visible in
vastai --helpand tab completion —search network-volumes,create network-volume,list network-volume,unlist network-volume.Adds a general-purpose "hidden command" gate, independent of and unrelated to the client/host work in #462/#463:
HIDDEN_COMMANDS(name-based registry) + an explicithidden=kwarg on@parser.command, mirroring the existingCOMMAND_OVERRIDES-style pattern invastai/cli/parser.py.vastai search network-volumes ...), so internal testing is unaffected.Found while manually testing #462 — noticed
search network-volumesin--helpbut its ownusage:string has an unrelated pre-existing typo (sayssearch network volumes, missing the hyphen, present onmastertoo). Not fixed here since it's a separate, small, unrelated issue — happy to do it as a follow-up if wanted.Test plan
poetry run pytest tests/cli— 375 passedvastai --helpor tab completion; all four still parse and run when typed directly